Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs (#145): break out custom directives api migration into its own s… #146

Merged
merged 5 commits into from
Jul 13, 2020

Conversation

bencodezen
Copy link
Member

Primarily took what Sarah wrote and added some headings to be consistent with the new format we're using to provide users with a more uniform experience across each guide

Copy link
Member

@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this @bencodezen 🙇

I've added a few comments 😄

src/guide/migration/custom-directives.md Outdated Show resolved Hide resolved
src/guide/migration/custom-directives.md Outdated Show resolved Hide resolved
src/guide/migration/custom-directives.md Outdated Show resolved Hide resolved
@bencodezen
Copy link
Member Author

Thanks for the review @NataliaTepluhina! I fixed up the parts you commented. Let me know if you see anything else!

Copy link
Member

@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bencodezen! Rest looks good to me 👍

@bencodezen bencodezen merged commit ca9b26e into master Jul 13, 2020
@NataliaTepluhina NataliaTepluhina deleted the docs/145-custom-directives-api branch July 17, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Custom Directive API migration guide section
2 participants