Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client & devtools-kit): add route-meta for pages #560

Merged
merged 7 commits into from
Sep 3, 2024

Conversation

wzc520pyfm
Copy link
Contributor

@wzc520pyfm wzc520pyfm commented Aug 3, 2024

hi~! I see #330 , this pr add route meta for pages.

Preview:

route-meta-for-pages-2.mp4

Copy link

netlify bot commented Aug 3, 2024

Deploy Preview for vue-devtools-docs canceled.

Name Link
🔨 Latest commit 966cc05
🔍 Latest deploy log https://app.netlify.com/sites/vue-devtools-docs/deploys/66d7396717bc7c0008c5bd5a

pnpm-lock.yaml Outdated Show resolved Hide resolved
@alexzhang1030
Copy link
Member

the bundle size of json-editor-vue is above 500kb, this is huge... Since this is not a feature for high-frequency use, and most of the time is read instead of edited, how about just using Shiki for render meta info? We have a CodeBlock component on the @vue/devtools-ui package.

@wzc520pyfm
Copy link
Contributor Author

the bundle size of json-editor-vue is above 500kb, this is huge... Since this is not a feature for high-frequency use, and most of the time is read instead of edited, how about just using Shiki for render meta info? We have a CodeBlock component on the @vue/devtools-ui package.

Sorry for delay. I have replaced json-editor-vue with CodeBlock.

Copy link
Member

@alexzhang1030 alexzhang1030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

A screen record:

route-meta.mp4

@webfansplz
Copy link
Member

Because the route meta info does not exist in every project, I think it is better UX to hide this field if all the routes of the user project do not have this field.

@webfansplz webfansplz merged commit 344987a into vuejs:main Sep 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants