Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(runtime-core): use 'createTextVNode' replacement 'createVNode' for to improve the readability of the code #5630

Closed
wants to merge 1 commit into from

Conversation

cuixiaorui
Copy link
Contributor

To improve the readability of the code

@netlify
Copy link

netlify bot commented Mar 26, 2022

Deploy Preview for vuejs-coverage ready!

Name Link
🔨 Latest commit ee1e1a5
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/623f105ab9607400080d7f14
😎 Deploy Preview https://deploy-preview-5630--vuejs-coverage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 26, 2022

Deploy Preview for vue-sfc-playground ready!

Name Link
🔨 Latest commit ee1e1a5
🔍 Latest deploy log https://app.netlify.com/sites/vue-sfc-playground/deploys/623f105a95976000082ed050
😎 Deploy Preview https://deploy-preview-5630--vue-sfc-playground.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 26, 2022

Deploy Preview for vue-next-template-explorer ready!

Name Link
🔨 Latest commit ee1e1a5
🔍 Latest deploy log https://app.netlify.com/sites/vue-next-template-explorer/deploys/623f105a2b971a000809d11e
😎 Deploy Preview https://deploy-preview-5630--vue-next-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@yyx990803
Copy link
Member

yyx990803 commented May 27, 2024

Thank you for the PR! This might be late but we appreciate your contribution regardless.

I prefer to keep the original so that we avoid an extra call; createTextVNode is an exported helper to reduce bundle size because it can appear many times in generated code.

@yyx990803 yyx990803 closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Rejected
Development

Successfully merging this pull request may close these issues.

2 participants