Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v-once): setting hasOnce to current block only when in v-once #12374

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

edison1105
Copy link
Member

close #12371

Copy link

github-actions bot commented Nov 13, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (+8 B) 38 kB (+3 B) 34.2 kB (+24 B)
vue.global.prod.js 159 kB (+62 B) 57.9 kB (+29 B) 51.5 kB (+80 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.9 kB (+22 B) 18.3 kB (+10 B) 16.7 kB (+15 B)
createApp 55 kB (+22 B) 21.3 kB (+16 B) 19.5 kB (+80 B)
createSSRApp 59 kB (+22 B) 23 kB (+12 B) 20.9 kB (-71 B)
defineCustomElement 59.8 kB (+22 B) 22.8 kB (+6 B) 20.8 kB (+11 B)
overall 68.7 kB (+8 B) 26.4 kB (+4 B) 24 kB (-26 B)

Copy link

pkg-pr-new bot commented Nov 13, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12374

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12374

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12374

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12374

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12374

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12374

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12374

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12374

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12374

vue

pnpm add https://pkg.pr.new/vue@12374

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12374

commit: 2127485

@edison1105 edison1105 added ready to merge The PR is ready to be merged. ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. labels Nov 13, 2024
@yyx990803 yyx990803 merged commit 37300fc into main Nov 14, 2024
15 checks passed
@yyx990803 yyx990803 deleted the edison/fix/12371 branch November 14, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. ready to merge The PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling a slot's render function causes components to not be properly unmounted in certain conditions
2 participants