fix(runtime-core): Correct update renders both old and new dynamic child node arrays are empty #7266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ild node arrays are empty
❌ Deploy Preview for vuejs-coverage failed.
|
edison1105
reviewed
Dec 3, 2022
| (__DEV__ && isHmrUpdating) || | ||
| (dynamicChildren && | ||
| prevDynamicChildren && | ||
| dynamicChildren.length === 0 && |
There was a problem hiding this comment.
This change is incorrect and may lead to unnecessary updates since empty dynamicChildren means no patch is needed in the fast path.
I think we should not track block if the entire node is static.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Size ReportBundles
Usages
|
# Conflicts: # packages/runtime-core/__tests__/rendererOptimizedMode.spec.ts # packages/runtime-core/src/renderer.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #7256