fix(hmr): avoid infinite recursion when reloading hmr components (#6930) #6936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edison1105
requested changes
Oct 25, 2022
|
|
||
| // #6930 avoid infinite recursion when reloading hmr components | ||
| if (__DEV__ && hmrDirtyComponents.has(instance.type)) { | ||
| hmrDirtyComponents.delete(instance.type) |
There was a problem hiding this comment.
Good catch!
I feel we should delete the dirty component here:
core/packages/runtime-core/src/hmr.ts
Line 138 in b0b74a1
change the code as blow:
queueJob(() => {
instance.parent.update()
hmrDirtyComponents.delete(oldComp)
})There was a problem hiding this comment.
Thanks a lot for the suggestion!
zhangzhonghe
force-pushed
the
fix-6930
branch
2 times, most recently
from
5392bfd
to
ebea034
Compare
edison1105
approved these changes
Oct 25, 2022
zhangzhonghe
force-pushed
the
fix-6930
branch
from
ebea034
to
b446fe3
Compare
zhangzhonghe
force-pushed
the
fix-6930
branch
from
b446fe3
to
5dde129
Compare
haoqunjiang
added
🔨 p3-minor-bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6930