Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

this is no longer passed for the first argument of this.$watch #2731

Closed
LongTengDao opened this issue Dec 5, 2020 · 0 comments · Fixed by #2753
Closed

this is no longer passed for the first argument of this.$watch #2731

LongTengDao opened this issue Dec 5, 2020 · 0 comments · Fixed by #2753
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. 🐞 bug Something isn't working

Comments

@LongTengDao
Copy link
Contributor

LongTengDao commented Dec 5, 2020 •
edited
Loading

Version

3.0.4

Reproduction link

Vue 2: https://jsfiddle.net/skirtle/5mhLtuqx
Vue 3: https://jsfiddle.net/skirtle/fo1bh34x

by @ skirtles-code at vuejs/docs#722

Steps to reproduce

The first argument expOrFn of this.$watch (and Vue.watch) couldn't receive the first argument vm (which equals to this) any more.

What is expected?

Add the first argument back, or write this change in doc

What is actually happening?

Only this left currently since Vue 3.
@LongTengDao LongTengDao mentioned this issue Dec 5, 2020
Closed
@posva posva changed the title confirm whether the breaking change of watch is a bug this is no longer passed as the first argument of this.$watch Dec 7, 2020
@posva posva added 🐞 bug Something isn't working 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels Dec 7, 2020
@edison1105 edison1105 mentioned this issue Dec 7, 2020
Merged
@LongTengDao LongTengDao changed the title this is no longer passed as the first argument of this.$watch this is no longer passed for the first argument of this.$watch Dec 10, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. 🐞 bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@posva @LongTengDao