fix(hydration): provide compat fallback for idle callback #11935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for vue-next-template-explorer failed.
|
❌ Deploy Preview for vue-sfc-playground failed.
|
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
@vue/compat
vue
commit: |
12 tasks
yyx990803
requested changes
Sep 16, 2024
edison1105
reviewed
Sep 16, 2024
edison1105
reviewed
Sep 16, 2024
edison1105
reviewed
Sep 16, 2024
yyx990803
requested changes
Sep 18, 2024
| import { DOMNodeTypes, isComment } from './hydration' | ||
|
|
||
| const globalThis = getGlobalThis() |
There was a problem hiding this comment.
Move this into the functions where it's needed and call it inline (it's cached) so that this can be treeshaken with the functions
There was a problem hiding this comment.
Typescript appears to have issues with this approach
| // https://github.com/nuxt/nuxt/blob/main/packages/nuxt/src/app/compat/idle-callback.ts | ||
| // Polyfills for Safari support | ||
| // https://caniuse.com/requestidlecallback | ||
| const requestIdleCallback: typeof getGlobalThis().requestIdleCallback = |
There was a problem hiding this comment.
this should not be like this ReturnType<typeof getGlobalThis>['requestIdleCallback'] ?
edison1105
added
ready to merge
yyx990803
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a compatibility polyfill for idle callback, which is not supported in Safari. The implementation is taken straight from Nuxt's.