Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vue3.5: defineAsyncComponent in keep-alive the hook onActivated is not called #11916

Closed
pmengy opened this issue Sep 13, 2024 · 1 comment · Fixed by #11917
Closed

Vue3.5: defineAsyncComponent in keep-alive the hook onActivated is not called #11916

pmengy opened this issue Sep 13, 2024 · 1 comment · Fixed by #11917
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. regression scope: keep-alive

Comments

@pmengy
Copy link

pmengy commented Sep 13, 2024

Vue version

3.5.4

Link to minimal reproduction

https://github.com/ritilyn1991/testdemo.git

Steps to reproduce

npm i
npm run dev
http://localhost:8080/test1

What is expected?

console.info('activated-test1')

What is actually happening?

no console

System Info

No response

Any additional comments?

use Vue3.4 version: defineAsyncComponent in keep-alive the hook onActivated is called
use Vue3.5 version: the hook onActivated is not called
@edison1105 edison1105 added scope: keep-alive 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. regression ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. and removed 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels Sep 13, 2024
@edison1105
Copy link
Member

reproduction with playground

@edison1105 edison1105 mentioned this issue Sep 13, 2024
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. regression scope: keep-alive
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(runtime-core): properly update async component nested in KeepAlive vuejs/core
2 participants
@edison1105 @pmengy