Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(vue-model): does not pass values when using an object string #11163

Closed
thetaPC opened this issue Jun 17, 2024 · 1 comment · Fixed by #11165
Closed

bug(vue-model): does not pass values when using an object string #11163

thetaPC opened this issue Jun 17, 2024 · 1 comment · Fixed by #11165
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. 🐞 bug Something isn't working scope: custom elements

Comments

@thetaPC
Copy link

thetaPC commented Jun 17, 2024

Vue version

3.4.28+

Link to minimal reproduction

https://stackblitz.com/edit/vpo3zh?file=src%2Fcomponents%2FExample.vue

Steps to reproduce

Ionic Framework has a ion-range that can be set for dual knobs by passing a string object to the value.

  1. Make sure to use Vue 3.4.28+
  2. Navigate to the repro to see the dual knobs of ion-range.
  3. Notice that the first knob has a value of 20 and the second knob has a value of 80.
  4. The knobs render as a value of 0

What is expected?

I expect that the knobs render at the correct values. The correct render can be viewed at this additional repro that has Vue 3.4.27.

What is actually happening?

It seems that Vue 3.4.28+ is not passing the string object. It converts it to a NaN instead which leads to the knobs rendering at the 0 position. This is happening when ion-range is using dual knobs. However, no issues are found when downgrading to Vue 3.4.27.

System Info

System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.20.3 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.3 - /usr/local/bin/npm
    pnpm: 8.15.6 - /usr/local/bin/pnpm
  npmPackages:
    vue: ^3.4.28 => 3.4.28

Any additional comments?

We noticed this bug after a CI check failed. There hasn't been any changes to the ion-range since last month. The only thing that has changed was a patch release from Vue.

@yangxiuxiu1115
Copy link
Contributor

537a571

@LinusBorg LinusBorg added 🐞 bug Something isn't working ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. scope: custom elements labels Jun 18, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. 🐞 bug Something isn't working scope: custom elements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants