Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-core): don't inline isShallow #10238

Merged
merged 1 commit into from
Feb 5, 2024
Merged

fix(runtime-core): don't inline isShallow #10238

merged 1 commit into from
Feb 5, 2024

Conversation

sxzz
Copy link
Member

@sxzz sxzz commented Jan 30, 2024

isShallow is inline-imported in runtime-core.esm-bundler.js, line 7937

@sxzz sxzz requested a review from yyx990803 January 30, 2024 11:23
@github-actions GitHub Actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 90.2 kB 34.4 kB 30.9 kB
vue.global.prod.js 147 kB 53.6 kB 47.8 kB

Usages

Name Size Gzip Brotli
createApp 50.3 kB 19.7 kB 18 kB
createSSRApp 53.7 kB 21 kB 19.1 kB
defineCustomElement 52.6 kB 20.4 kB 18.6 kB
overall 64 kB 24.8 kB 22.5 kB

@yyx990803 yyx990803 merged commit 53eee72 into main Feb 5, 2024
15 checks passed
@yyx990803 yyx990803 deleted the fix/dedupe-isShallow branch February 5, 2024 03:36
lynxlangya pushed a commit to lynxlangya/core that referenced this pull request May 30, 2024
@sxzz @lynxlangya
fix(runtime-core): avoid inlining isShallow (vuejs#10238)
2fc2edc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyx990803 yyx990803 Awaiting requested review from yyx990803

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sxzz @yyx990803