fix(ssr): add support for overloaded boolean attributes

Author: chirokas

packages/compiler-ssr/__tests__/ssrElement.spec.ts

@@ -191,6 +191,20 @@ describe('ssr: element', () => {
         `)
     })
 
+    test('v-bind:arg (overloaded boolean)', () => {
+      expect(
+        getCompiledString(
+          `<div><span :hidden="false"></span><span :hidden="'until-found'"></span></div>`,
+        ),
+      ).toMatchInlineSnapshot(`
+        "\`<div><span\${
+            _ssrRenderDynamicAttr("hidden", false)
+          }></span><span\${
+            _ssrRenderDynamicAttr("hidden", 'until-found')
+          }></span></div>\`"
+      `)
+    })
+
     test('v-bind:[arg]', () => {
       expect(getCompiledString(`<div v-bind:[key]="value"></div>`))
         .toMatchInlineSnapshot(`

packages/compiler-ssr/src/transforms/ssrTransformElement.ts

@@ -38,6 +38,7 @@ import {
   escapeHtml,
   isBooleanAttr,
   isBuiltInDirective,
+  isOverloadedBooleanAttr,
   isSSRSafeAttrName,
   propsToAttrMap,
 } from '@vue/shared'
@@ -287,6 +288,13 @@ export const ssrTransformElement: NodeTransform = (node, context) => {
                         false /* no newline */,
                       ),
                     )
+                  } else if (isOverloadedBooleanAttr(attrName)) {
+                    openTag.push(
+                      createCallExpression(
+                        context.helper(SSR_RENDER_DYNAMIC_ATTR),
+                        [key, value],
+                      ),
+                    )
                   } else if (isSSRSafeAttrName(attrName)) {
                     openTag.push(
                       createCallExpression(context.helper(SSR_RENDER_ATTR), [

packages/server-renderer/__tests__/ssrRenderAttrs.spec.ts

@@ -131,13 +131,6 @@ describe('ssr: renderAttr', () => {
       ` foo="${escapeHtml(`<script>`)}"`,
     )
   })
-
-  test('combined boolean/string attribute', () => {
-    expect(ssrRenderAttr('hidden', true)).toBe(` hidden`)
-    expect(ssrRenderAttr('hidden', false)).toBe('')
-    expect(ssrRenderAttr('hidden', 'until-found')).toBe(` hidden="until-found"`)
-    expect(ssrRenderAttr('hidden', '')).toBe(` hidden`)
-  })
 })
 
 describe('ssr: renderClass', () => {

packages/server-renderer/src/helpers/ssrRenderAttrs.ts

@@ -84,9 +84,6 @@ export function ssrRenderAttr(key: string, value: unknown): string {
   if (!isRenderableAttrValue(value)) {
     return ``
   }
-  if (isOverloadedBooleanAttr(key) && isBooleanAttrValue(value)) {
-    return includeBooleanAttr(value) ? ` ${key}` : ``
-  }
   return ` ${key}="${escapeHtml(value)}"`
 }