Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetchResults has no change on useQuery #1060

Closed
brunomperes opened this issue Sep 24, 2020 · 2 comments · Fixed by Shoutzor/frontend#141 or Shoutzor/frontend#175 · May be fixed by Shoutzor/frontend#176 or Shoutzor/frontend#178
Closed

fetchResults has no change on useQuery #1060

brunomperes opened this issue Sep 24, 2020 · 2 comments · Fixed by Shoutzor/frontend#141 or Shoutzor/frontend#175 · May be fixed by Shoutzor/frontend#176 or Shoutzor/frontend#178
Labels

Comments

@brunomperes
Copy link

Describe the bug
On v4, passing the option fetchResults: false to useQuery has no effect (and if it had any I'm not clear how it is different from enabled: false)

To Reproduce
Steps to reproduce the behavior:

  1. Add fetchResults: false option to a component with composition API
  2. Render the page
  3. See component still fetching results on the server and on the client

Expected behavior
From what I see this option only exists in the v4 branch in a doc page and in a test.

So perhaps it's a leftover from v3 and it's just a matter of removing it.

If it is to be implemented though, ideally would be clear what is the difference between fetchResults and enabled

Versions
vue: 2.6.12
vue-apollo: v4.0.0-alpha.10
apollo-client: 3.1.2

Additional context
Link to docs page: https://v4.apollo.vuejs.org/api/use-query.html#parameters

@Akryum Akryum added the v4 label Oct 15, 2020
@karladler
Copy link

This seems to be still an issue or it requires some documentation.

@karladler
Copy link

any update here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment