Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guide > Application & Component Instances の翻訳を追従 #273

Merged
merged 5 commits into from
Apr 24, 2021
Merged

Guide > Application & Component Instances の翻訳を追従 #273

merged 5 commits into from
Apr 24, 2021

Conversation

naokie
Copy link
Member

@naokie naokie commented Apr 23, 2021

skirtles-code and others added 4 commits April 23, 2021 13:21
* docs: experimental rewrite of instance.md, introducing data-methods.md

* docs: cut material from instance.md that isn't on topic

* docs: move data-methods.md to after template-syntax.md

* fix: change 'application' to 'component' in template-syntax.md

* fix: use bold when introducing new terms in instance.md

* docs: rewrite data-methods.md
@netlify
Copy link

netlify bot commented Apr 23, 2021

Deploy preview for vuejs-v3-ja-doc-preview ready!

Built with commit d284b7f

https://deploy-preview-273--vuejs-v3-ja-doc-preview.netlify.app

Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レビューしました。
いくつかコメントしたので、確認お願いします!

src/guide/instance.md Show resolved Hide resolved
src/guide/instance.md Show resolved Hide resolved
src/guide/instance.md Outdated Show resolved Hide resolved
Co-authored-by: kazuya kawaguchi <[email protected]>
@naokie
Copy link
Member Author

naokie commented Apr 24, 2021

レビューありがとうございました!
Suggestion してもらったもの取り込んで、修正反映済みです。

@kazupon
Copy link
Member

kazupon commented Apr 24, 2021

ありがとうございます!
マージします!

@kazupon kazupon merged commit 58a5fda into vuejs-jp:lang-ja Apr 24, 2021
@naokie naokie deleted the guide/instance branch April 24, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants