New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code re usability is missing #10

Open

sivakumarkoduru opened this issue Jun 16, 2020 · 0 comments

sivakumarkoduru commented Jun 16, 2020

https://github.com/vuefront/opencart/blob/master/catalog/model/extension/d_vuefront/address.php

https://github.com/opencart/opencart/blob/master/upload/catalog/model/account/address.php

compare above files.

We should use opencart model objects instead of that again writing same code in files.

we will miss important opencart core code changes.

for example in latest version string casting is there in sql quereis.please check above opencart model address file.

i hope you got my point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment