Throw early if control OID is not present.

dfish3r · dfish3r · commit 02eefd9038a4 · 2024-04-11T10:35:30.000-04:00
diff --git a/core/src/main/java/org/ldaptive/AbstractMessage.java b/core/src/main/java/org/ldaptive/AbstractMessage.java
@@ -171,9 +171,12 @@ public void handle(final DERParser parser, final DERBuffer encoded)
     {
       final ControlParser p = new ControlParser();
       p.parse(encoded);
+      if (p.getOid().isEmpty()) {
+        throw new IllegalArgumentException("Cannot parse response control without OID");
+      }
       getObject().addControls(
         ControlFactory.createResponseControl(
-          p.getOid().isPresent() ? p.getOid().get() : null,
+          p.getOid().get(),
           p.getCritical().isPresent() ? p.getCritical().get() : false,
           p.getValue().isPresent() ? p.getValue().get() : null));
     }

Original file line number	Diff line number	Diff line change
`@@ -171,9 +171,12 @@ public void handle(final DERParser parser, final DERBuffer encoded)`
`171`	`171`	`{`
`172`	`172`	`final ControlParser p = new ControlParser();`
`173`	`173`	`p.parse(encoded);`
	`174`	`+ if (p.getOid().isEmpty()) {`
	`175`	`+ throw new IllegalArgumentException("Cannot parse response control without OID");`
	`176`	`+ }`
`174`	`177`	`getObject().addControls(`
`175`	`178`	`ControlFactory.createResponseControl(`
`176`		`- p.getOid().isPresent() ? p.getOid().get() : null,`
	`179`	`+ p.getOid().get(),`
`177`	`180`	`p.getCritical().isPresent() ? p.getCritical().get() : false,`
`178`	`181`	`p.getValue().isPresent() ? p.getValue().get() : null));`
`179`	`182`	`}`