Remove vpnotebook dependency #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is no longer needed (it used to import numpy, and a couple of other things) because we handle imports in the core vpython code. Editorial: custom kernels installed in --user can also mask kernels in --sys-prefix (i.e. in a virtual environment) leading to confusion about which python is actually running.
The stuff in run_test.py was checking for a kernel that is no longer required, and working around import issues in Python 2.7 and 3.4, neither of which is supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is no longer needed (it used to import numpy, and a couple of other
things) because we handle imports in the core vpython code.
This fixes #13.
Editorial:
custom kernels installed in --user can also mask kernels in --sys-prefix
(i.e. in a virtual environment) leading to confusion about which python
is actually running.