Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operatingsystem_support wrongly used #82

Closed
Dan33l opened this issue Sep 24, 2019 · 3 comments
Closed

operatingsystem_support wrongly used #82

Dan33l opened this issue Sep 24, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@Dan33l
Copy link
Member

Dan33l commented Sep 24, 2019

Last sync was 2019-09-24 16:55:37 UTC and puppet-openvpn is reported with missing operatingsystem_support.
But metadata.json of the module have this section:
https://github.com/voxpupuli/puppet-openvpn/blob/master/metadata.json#L11

@dhoppe
Copy link
Member

dhoppe commented Nov 29, 2019

I think this happens, because vox-pupuli-tasks is missing a list of releases.

begin
metadata['operatingsystem_support'].each do |os|
case os['operatingsystem']
when 'Ubuntu'
if os['operatingsystemrelease'].min < UBUNTU_SUPPORT_RANGE.min
data.supports_eol_ubuntu << repo
end
if os['operatingsystemrelease'].max < UBUNTU_SUPPORT_RANGE.max
data.doesnt_support_latest_ubuntu << repo
end
when 'Debian'
if os['operatingsystemrelease'].all_i.min < DEBIAN_SUPPORT_RANGE.all_i.min
data.supports_eol_debian << repo
end
if os['operatingsystemrelease'].all_i.max < DEBIAN_SUPPORT_RANGE.all_i.max
data.doesnt_support_latest_debian << repo
end
when 'CentOS', 'RedHat'
if os['operatingsystemrelease'].all_i.min < CENTOS_SUPPORT_RANGE.all_i.min
data.supports_eol_centos << repo
end
if os['operatingsystemrelease'].all_i.max < CENTOS_SUPPORT_RANGE.all_i.max
data.doesnt_support_latest_centos << repo
end
when 'FreeBSD'
if os['operatingsystemrelease'].all_i.min < FREEBSD_SUPPORT_RANGE.all_i.min
data.supports_eol_freebsd << repo
end
if os['operatingsystemrelease'].all_i.max < FREEBSD_SUPPORT_RANGE.all_i.max
data.doesnt_support_latest_freebsd << repo
end
when 'Fedora'
if os['operatingsystemrelease'].all_i.min < FEDORA_SUPPORT_RANGE.all_i.min
data.supports_eol_fedora << repo
end
if os['operatingsystemrelease'].all_i.max < FEDORA_SUPPORT_RANGE.all_i.max
data.doesnt_support_latest_fedora << repo
end
end
end

@Flipez
Copy link
Member

Flipez commented Apr 29, 2020

Hi @Dan33l

You are missing operatingsystemrelease for FreeBDS: https://github.com/voxpupuli/puppet-openvpn/blob/master/metadata.json#L46

Therefore our logic raises this - not very helpful - error. If you fix this the error will disappear.

We will rework the whole logic of the RepoStatusWorker soon and will improve these errors and messages.

#146

@Flipez Flipez added the bug Something isn't working label Apr 29, 2020
@Flipez
Copy link
Member

Flipez commented Aug 29, 2021

I'll close this since the checks seem to work now better and do display the correct information (https://voxpupu.li/repositories/puppet-openvpn)

@Flipez Flipez closed this as completed Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants