Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notify Contributor / label PR if checks fail #2

Closed
bastelfreak opened this issue Jun 9, 2019 · 1 comment · Fixed by #144
Closed

Notify Contributor / label PR if checks fail #2

bastelfreak opened this issue Jun 9, 2019 · 1 comment · Fixed by #144
Labels
backend/notifier User gets notified via mail, hook, comment... enhancement New feature or request
Milestone
merge conflicts

Comments

@bastelfreak
Copy link
Member

bastelfreak commented Jun 9, 2019 •
edited
Loading

GitHub API allows us to check if a CI job failed (the new travis check uses a different API than the older travis webhook integration). PRs with the failed job need the label tests-fail. The label needs to be removed when the CI passes again.

It's probably a good idea to also put a comment into the PR because people don't get emails when a label is added/removed. The text for the comment should come from generic config file (we need to keep in mind that other orgs might want to roll this out too).
@bastelfreak bastelfreak added the enhancement New feature or request label Jun 9, 2019
@bastelfreak bastelfreak added this to the merge conflicts milestone Jul 31, 2019
@bastelfreak
Copy link
Member Author

partly implemented in #35

@Flipez Flipez added the backend/notifier User gets notified via mail, hook, comment... label Sep 21, 2019
@Flipez Flipez mentioned this issue Apr 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend/notifier User gets notified via mail, hook, comment... enhancement New feature or request
Projects
None yet
Milestone
merge conflicts
Development

Successfully merging a pull request may close this issue.

Set a PR label / comment if CI passes/fails voxpupuli/vox-pupuli-tasks
2 participants
@bastelfreak @Flipez