Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Zabbix 5.x #743

Merged
merged 10 commits into from
Mar 14, 2021
Merged

Conversation

root-expert
Copy link
Member

@root-expert root-expert commented Feb 28, 2021

Pull Request (PR) description

Adds support for Zabbix 5.x.
Maybe more tests are needed
Depends on #742

This Pull Request (PR) fixes the following issues

Fixes #731
Closes #737
Closes #736
Closes #721
Closes #715
Closes #694

Copy link
Contributor

@DJClean DJClean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I was looking into upgrading to Zabbix 5.0 myself, looked into this PR

But it seems to break on web.pp because of the custom_fragment with all the php_value settings
The var $apache_vhost_custom_fragment is being set, but not used to set the fragment in the vhost if I saw it right. Overall it seems to work just fine if I remove the fragment manually

@root-expert
Copy link
Member Author

Thanks! I'll look into it and report back

@DJClean
Copy link
Contributor

DJClean commented Mar 3, 2021

Already pushed a PR to your branch with the fix :)

@root-expert root-expert force-pushed the zabbix5_support branch 7 times, most recently from bed5f23 to bdb2c26 Compare March 6, 2021 18:00
@root-expert root-expert force-pushed the zabbix5_support branch 6 times, most recently from 6ad137f to a54f037 Compare March 6, 2021 22:44
@root-expert root-expert force-pushed the zabbix5_support branch 3 times, most recently from 0b76498 to d6f3639 Compare March 7, 2021 22:29
@jameskirsop
Copy link
Contributor

Could we also consider rolling in my branch for adding support for the SAML / SSO settings introduced in 5.x? Doing this will allow #693 to be closed.

If it's deemed not appropriate I'll file a seperate PR.

@jadestorm
Copy link

Not to pile on =) But this setting is pretty important for Zabbix 5:
#734
(it has a PR already)

@jadestorm
Copy link

PS aside from that I am using @root-expert 's PR fork directly right now for my 5.2 install and it's working great! Mind you I'm not (yet) using the exported resources functionality.

@root-expert
Copy link
Member Author

Could we also consider rolling in my branch for adding support for the SAML / SSO settings introduced in 5.x? Doing this will allow #693 to be closed.

If it's deemed not appropriate I'll file a seperate PR.

I think you should open a new request after rebasing with my branch. Also you should write some specs ;)

Not to pile on =) But this setting is pretty important for Zabbix 5:
#734
(it has a PR already)

I believe that PR could be merged if rebased as well.

@bastelfreak bastelfreak added the enhancement New feature or request label Mar 14, 2021
@bastelfreak bastelfreak merged commit d6ec11b into voxpupuli:master Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the install action for zabbix 5.0 on centos/redhat 7 is wrong
6 participants