Add option to specify type of interface in agent class #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can someone take a look at this please? |
bastelfreak
reviewed
Nov 3, 2020
| @@ -16,8 +16,12 @@ def self.instances | |||
| ) | |||
|
|
|||
| api_hosts.map do |h| | |||
| interface = h['interfaces'].select { |i| i['type'].to_i == 1 && i['main'].to_i == 1 }.first | |||
| interface = h['interfaces'].select { |i| i['main'].to_i == 1 }.first | |||
There was a problem hiding this comment.
can you add some inline comments to describe the magic that's happening here?
bastelfreak
reviewed
Nov 3, 2020
manifests/agent.pp
Outdated
| @@ -253,6 +256,7 @@ | |||
| $zbx_group_create = $zabbix::params::agent_zbx_group_create, | |||
| $zbx_templates = $zabbix::params::agent_zbx_templates, | |||
| Array[Hash] $zbx_macros = [], | |||
| Integer $zbx_interface_type = 1, | |||
There was a problem hiding this comment.
can you enforce the datatype a bit more? are negative values allowed? I think there is an upper limit that could be enforced as well?
bastelfreak
added
enhancement
|
@bastelfreak I've made the requested changes and rebased to current master |
bastelfreak
approved these changes
Nov 6, 2020
bastelfreak
approved these changes
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This pull request adds option to specify interface type in agent.pp, so you can create an agent that is purely SNMP/JMX/IPMI.