Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use older xenial docker image #673

Merged
merged 1 commit into from
Apr 12, 2020
Merged

Use older xenial docker image #673

merged 1 commit into from
Apr 12, 2020

Conversation

alexjfisher
Copy link
Member

@alexjfisher alexjfisher commented Apr 12, 2020 •
edited
Loading

Needed because of docker/for-linux#835

Also see 8496ed3

dhoppe
dhoppe reviewed Apr 12, 2020
View reviewed changes
Copy link
Member

@dhoppe dhoppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to use an older image?

@alexjfisher
Copy link
Member Author

Why do we need to use an older image?

To fix the tests. Now that they're passing, I've updated the commit message and PR comment with explanation.

@ekohl ekohl merged commit 5c86819 into voxpupuli:master Apr 12, 2020
@alexjfisher alexjfisher deleted the fix_tests branch April 13, 2020 10:02
@alexjfisher alexjfisher mentioned this pull request May 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhoppe dhoppe dhoppe approved these changes

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexjfisher @ekohl @dhoppe