Add logtype parameter for zabbix server (issue #394)

[dpavlotzky]

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

[bastelfreak]

Hi @dpavlotzky, thanks for the PR. Can you please take a look at the used email address? It isn't associated with your github account.

Is the log setup only specific for the server, or also for the agent? If so, the agent code would need to be updated as well.

[dpavlotzky]

@bastelfreak I have updated the email address of my Github account. The agent already has the logtype parameter:

puppet-zabbix/manifests/params.pp

Lines 272 to 281 in fdd5fd1

	# provided by camp2camp/systemd
	if $facts['systemd'] {
	$agent_logtype = 'system'
	$agent_logfile = undef
	$agent_logfilesize = undef
	} else {
	$agent_logtype = 'file'
	$agent_logfile = '/var/log/zabbix/zabbix_agentd.log'
	$agent_logfilesize = '100'
	}

puppet-zabbix/manifests/agent.pp

Line 235 in fdd5fd1

String $logtype = $zabbix::params::agent_logtype,

[dpavlotzky]

The test build fails because a trailing comma is missing:

$ bundle exec rake $CHECK
manifests/server.pp:316:trailing_comma:WARNING:missing trailing comma after last element
The command "bundle exec rake $CHECK" exited with 1.

The complaint is about the following code:

https://github.com/dpavlotzky/puppet-zabbix/blob/afb8643095fca155d8e4df43af2ae9e935e60b35/manifests/server.pp#L313-L317

But the complaint is incorrect: adding a trailing comma here is a syntax error.

I will inline the Enum, but that is less pretty IMHO. Maybe someone can have a look at the test code to make it more robust.