Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tablespace parameter #644

Closed
wants to merge 17 commits into from
Closed

Add tablespace parameter #644

wants to merge 17 commits into from

Conversation

dpavlotzky
Copy link
Contributor

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

manifests/params.pp Outdated Show resolved Hide resolved
@baurmatt
Copy link
Contributor

baurmatt commented Jan 7, 2020

Hey @dpavlotzky, thanks for you contribution! :) Can you please check the following things?

  • Please address my comments
  • Please add at least rspec tests for the change
  • Please rebase the the branch after Pin CentOS acceptance tests 7.6.1810 #646 got merged. It fixed the error with the failing CentOS 7 acceptance tests.

@baurmatt baurmatt added the needs-work not ready to merge just yet label Jan 7, 2020
manifests/database.pp Outdated Show resolved Hide resolved
manifests/database.pp Outdated Show resolved Hide resolved
@baurmatt
Copy link
Contributor

Hey @dpavlotzky, thanks for the changes! :) Could you please squash you commits so that I can cleanly merge it?

bastelfreak and others added 17 commits January 14, 2020 14:09
This module was required to support EOL Puppet/Puppet Enterprise
versions. We don't support them since a long time, so we can remove the
dependency + related code.
This is needed because of docker/for-linux#835
and moby/moby#38749.

Long story short: systemd on CentOS 7.7 is broken with current versions
of Docker.
This is another change for #570.
For PostgreSQL databases this van be used to add the
database to a custom tablespace.
@dpavlotzky
Copy link
Contributor Author

Sorry! Messed up the squash :-(. Created a new pull-request #649

@dpavlotzky dpavlotzky closed this Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase needs-work not ready to merge just yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants