Add Remote Commands capabilities on Zabbix Proxy #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI builds failed seem to be related with the PR #576 (Fix rspec tests for Gentoo). |
bastelfreak
reviewed
Dec 21, 2018
manifests/proxy.pp
Outdated
| @@ -347,6 +353,8 @@ | |||
| $hostname = $zabbix::params::proxy_hostname, | |||
| $listenport = $zabbix::params::proxy_listenport, | |||
| $sourceip = $zabbix::params::proxy_sourceip, | |||
| $enableremotecommands = $zabbix::params::proxy_enableremotecommands, | |||
There was a problem hiding this comment.
can you please add datatypes for both values? I assume both varaibles can only take integers with 0 as lowest value? So this could work:
Suggested change
| $enableremotecommands = $zabbix::params::proxy_enableremotecommands, | |
| Integer[0] $enableremotecommands = $zabbix::params::proxy_enableremotecommands, |
bastelfreak
reviewed
Dec 21, 2018
manifests/proxy.pp
Outdated
| @@ -347,6 +353,8 @@ | |||
| $hostname = $zabbix::params::proxy_hostname, | |||
| $listenport = $zabbix::params::proxy_listenport, | |||
| $sourceip = $zabbix::params::proxy_sourceip, | |||
| $enableremotecommands = $zabbix::params::proxy_enableremotecommands, | |||
| $logremotecommands = $zabbix::params::proxy_logremotecommands, | |||
There was a problem hiding this comment.
Suggested change
| $logremotecommands = $zabbix::params::proxy_logremotecommands, | |
| Integer[0] $logremotecommands = $zabbix::params::proxy_logremotecommands, |
|
Hi, Sorry for the delay, I updated the PR to the latest commit. The build 1138.1 give an error but I'm not sure that related to my changes. Can you check if it's all correct ? |
bastelfreak
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Has documented in the Zabbix Wiki, the proxy have some options (since 3.4) for remote commands execution. So this PR add two boolean options:
EnableRemoteCommandsandLogRemoteCommands.Source: https://www.zabbix.com/documentation/4.0/manual/appendix/config/zabbix_proxy
This Pull Request (PR) fixes the following issues
n/a