Properly require zabbixapi gem #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have no idea why the test breaks... If I comment out @alexjfisher Do you have an idea why? git history shows that you implemented the test. |
|
So seems like not getting a good night of sleeps helps solving problems.... The problem seems to be, that the |
baurmatt
force-pushed
the
feature/proper_require
branch
from
2e92089
to
bfea868
Compare
|
I can't work out how it passed before though... |
|
Thanks for fixing this @baurmatt ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR changes how we
requirethezabbixapito the recommended way by creating a feature for it which we later confine.This Pull Request (PR) fixes the following issues