-
-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Puppet 6.x support #542
Conversation
So I accept (and expected) that puppet 6 fails because the But I cannot reproduce this locally. I need to investigate this later. |
Okay I can now reproduce this. I tried to execute the tests with:
And puppet 6 is installed:
But via my package manager I pulled in puppet 5:
Deinstalling/updating my local puppet 5 package to puppet 6 allows me to reproduce the issue. I somehow expected a better environment isolation from bundler. I thought one of the primary usecases of bundler is the isolation between project-gems and systemwide-gems. @binford2k I can now confirm that this module fails on puppet 6 because of the yumrepo resource type missing in puppet core. |
Adding https://github.com/puppetlabs/puppetlabs-yumrepo_core to the |
This depends at least on voxpupuli/puppet-selinux#271 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use 6.1.0 instead of 7.0.0.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues