Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Puppet 6.x support #542

Merged
merged 5 commits into from
Oct 5, 2018
Merged

Add Puppet 6.x support #542

merged 5 commits into from
Oct 5, 2018

Conversation

bastelfreak
Copy link
Member

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

@bastelfreak
Copy link
Member Author

So I accept (and expected) that puppet 6 fails because the yumrepo resource got pulled out:
https://travis-ci.org/voxpupuli/puppet-zabbix/jobs/430699716#L900

But I cannot reproduce this locally. I need to investigate this later.

@bastelfreak
Copy link
Member Author

Okay I can now reproduce this. I tried to execute the tests with:

bundle exec rake spec_prep
bundle exec rspec spec/classes/agent_spec.rb

And puppet 6 is installed:

$ bundle list puppet
/home/bastelfreak/modulesync_config/modules/puppet-zabbix/.vendor/ruby/2.5.0/gems/puppet-6.0.0

But via my package manager I pulled in puppet 5:

$ pacman -Qi puppet
Name            : puppet
Version         : 5.5.3-1
Description     : Server automation framework and application
Architecture    : any
URL             : https://puppet.com/products/open-source-projects
Licenses        : Apache
Groups          : None
Provides        : None
Depends On      : facter  hiera
Optional Deps   : ruby-shadow: user password management
Required By     : None
Optional For    : None
Conflicts With  : None
Replaces        : None
Installed Size  : 6.96 MiB
Packager        : Christian Rebischke <[email protected]>
Build Date      : Wed 18 Jul 2018 08:49:30 PM CEST
Install Date    : Wed 19 Sep 2018 09:56:56 AM CEST
Install Reason  : Explicitly installed
Install Script  : Yes
Validated By    : Signature

Deinstalling/updating my local puppet 5 package to puppet 6 allows me to reproduce the issue. I somehow expected a better environment isolation from bundler. I thought one of the primary usecases of bundler is the isolation between project-gems and systemwide-gems. @binford2k I can now confirm that this module fails on puppet 6 because of the yumrepo resource type missing in puppet core.

@bastelfreak
Copy link
Member Author

bastelfreak commented Sep 21, 2018

Adding https://github.com/puppetlabs/puppetlabs-yumrepo_core to the .fixtures.yml works fine, but some other required types are also missing. Our selinux module needs the https://forge.puppet.com/puppetlabs/selinux_core as a dependency

@bastelfreak
Copy link
Member Author

This depends at least on voxpupuli/puppet-selinux#271

Copy link

@erosastyro erosastyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use 6.1.0 instead of 7.0.0.

@dhollinger dhollinger merged commit 8b22568 into voxpupuli:master Oct 5, 2018
@bastelfreak bastelfreak deleted the puppet6 branch October 5, 2018 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants