Fix listen_ip bug and relax interface regex #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old regex didn't match for enp0s5 for example. Other values are possible as well. We should match for ^e*
bastelfreak
force-pushed
the
fix_listen_ip_address
branch
4 times, most recently
from
0216638
to
5aa2114
Compare
bastelfreak
force-pushed
the
fix_listen_ip_address
branch
from
5aa2114
to
e70809e
Compare
alexjfisher
changed the title
alexjfisher
approved these changes
Mar 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
The old regex didn't match for enp0s5 for example. Other values are
possible as well. We should match for ^e*
This Pull Request (PR) fixes the following issues
Fixes #493