Provide acceptance tests for zabbix server #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As somebody may guess based on the branch name: The initial idea was to add proper acceptance testing in an archlinux docker environment. During that I discovered multiple issues in the existing codebase that also match other operatingsystems. |
bastelfreak
force-pushed
the
archlinux_docker
branch
from
541c051
to
77c504f
Compare
bastelfreak
force-pushed
the
archlinux_docker
branch
3 times, most recently
from
ef765f5
to
b917acf
Compare
the service got started as root, which is really bad. We now provide the correct default user based on the operatingsystem, the user can overwrite it and even start it as root if he wants (by passing zabbix_user => undef).
bastelfreak
force-pushed
the
archlinux_docker
branch
4 times, most recently
from
594de76
to
b28a27f
Compare
We only need to depend on the database, if one is actually used. the database_type var defaults to postgres, so we can't only rely on that. there is also a manage_database var. This allows us to only provision the zabbix-server on one node, and the database on a different one. We need to configure the systemd unit correctly for this.
bastelfreak
force-pushed
the
archlinux_docker
branch
2 times, most recently
from
66a723e
to
a0d990a
Compare
bastelfreak
changed the title
the server, as the agent, have issues with running selinux. their shipped policy isn't complete. As a workaround we provide our own selinux module.
We don't support RHEL5 anymore. It is EOL
bastelfreak
force-pushed
the
archlinux_docker
branch
from
a0d990a
to
00735e5
Compare
The official CentOS docker container disables the installation of RPM docs in the image via the yum.conf file. The added code will check beaker host platform for EL 7 and host hypervisor for docker and re-enable the installation of docs files. This change is due to zabbix-server-pgsql tests failing as it relies on a sample file provided in the RPM docs directory.
bastelfreak
force-pushed
the
archlinux_docker
branch
from
897a587
to
b0ece0a
Compare
shibumi
approved these changes
Jun 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.