Introduce rspec-puppet-facts for some tests #218
Conversation
this is a huge rewrite of the tests. we now test zabbix 2.4 and 3 on proxy and server on all supported OSes
|
this should get green except for:
can somebody review this please? (/me looks at @jyaworski) I've no clue why these for tests fail. Maybe sientifix linux has the wrong osfamily fact. |
|
ha awesome... I did the local tests withour STRICT_VARIABLES=yes... is there a nice way to automate the lsb* fact mocking? I would like to get rid of the manual style. Also what is the correct way to deal with the is_pe fact? |
|
|
||
| case $::operatingsystemrelease { | ||
| /\/sid$/ : { $releasename = regsubst($::operatingsystemrelease, '/sid$', '') } | ||
| default : { $releasename = $::lsbdistcodename } |
There was a problem hiding this comment.
Is lsbdistcodename a thing on newer facter? I seem to recall the lsb* facts being deprecated.
There was a problem hiding this comment.
Ionly know that it requires the lsb-release package installed and in general the facts are only present on Debian based systems. I was looking for alternative core facts but didn't find any :(
No description provided.