Travis CI setup: ensure all rspec tests pass #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Working on making this pass Travis CI. Seeing lint problems I did not observe locally now. |
|
@dj-wasabi This is ready for review now. I've used it to deploy my simple AIO zabbix server, so I know that the rspec test changes aren't affecting single node installations at least, and of course rspec tests themselves are passing. I did a little reformating to make the tests run faster but there is no net change in number of tests, just how they're grouped. |
|
With this and #163, a new version should be cut. As described above there should be no effective changes but it may be safer to go to |
dj-wasabi
added a commit
that referenced
this pull request
Feb 2, 2016
Travis CI setup: ensure all rspec tests pass
|
Many thanks for this! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update to the Travis CI configuration and a rewrite of all rspec tests that standardizes them using the same layout. It also includes the fixes to the code required to get the rspec tests to pass with Puppet 3 and 4.
It does remove Puppet 2.7 from the test matrix. 2.7 is no longer supported and rspec generates a ton of failures that cannot be fixed without massive rewrites to the code. I believe this is fine, but it is up to you to accept it or not.
Fixes #160