Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zabbix::repo doest not inherit zabbix::params #93

Closed
PHaroZ opened this issue May 26, 2015 · 1 comment
Closed

zabbix::repo doest not inherit zabbix::params #93

PHaroZ opened this issue May 26, 2015 · 1 comment

Comments

@PHaroZ
Copy link

PHaroZ commented May 26, 2015

If zabbix::repo is used outside of zabbix::server, zabbix::params is not inherited, in such case default param values are not well resolved :

class zabbix::repo(
  $manage_repo    = $zabbix::params::manage_repo,
  $zabbix_version = $zabbix::params::zabbix_version,
) {

$manage_repo & $zabbix_version are undefined.

This need occurs when apt configuration is done in a different stage than other job. My case (stage first is done before main)

  class {'::zabbix::repo':
    stage           =>  'first',
    manage_repo     =>  true,
    zabbix_version  =>  '2.4',
  }
  ...
  class {'::zabbix':
    zabbix_url      => 'zabbix.domain.tld',
    manage_firewall => true,
    manage_repo     => false,
    database_type   => 'postgresql',
  }

when i don't specify manage_repo & zabbix_version, ::zabbix::repo does nothing.

So, is it possible that zabbix::repo inherits zabbix::params to enable default values ?

@dj-wasabi
Copy link
Contributor

Hi @PHaroZ

I pushed an fix for this several days ago. Would you please verify this and close the ticket?
Or please leave an comment with issues, ideas etc. :-)

Thanks!

Kind regards,
Werner

@PHaroZ PHaroZ closed this as completed Jun 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants