Fix $hostinterfaceitem to not be an Fqdn. #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 29, 2020 16:15
As per the upstream documentation (https://www.zabbix.com/documentation/5.0/manual/appendix/config/zabbix_agentd), hostinterfaceitem should be a Zabbix item and NOT an FQDN. Closes voxpupuli#725
* gh/master: Fix $hostinterfaceitem to not be an Fqdn.
bastelfreak
reviewed
Jan 18, 2021
|
Hi @bjschafer, thanks for the PR. please take a look at the inline comment I made and also rebase against our latest master branch. can you please add a test that checks that it passes with a string that's not an fdqn? Otherwise I'm afraid in the future people might add the fqdn type again. |
|
@bjschafer can you please rebase against our current master branch and squash the commits? |
add test to fail if hostinterfaceitem is set to fqdn
|
Dear @bjschafer, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
|
hi @bjschafer can you update this PR with information provided in #953 otherwise I can reimplement it in a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
As per #725 and the upstream documentation,
zabbix::agent::hostinterfaceitemshould not be an FQDN as it refers to a Zabbix item.I did not set a type, to match the similar
$hostmetadataitem. Let me know if I should instead set it to be something likeOptional[String].This Pull Request (PR) fixes the following issues
Fixes #725