Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrivateDevices=yes stops fping from working on Ubuntu 18.04 #609

Closed
trenta opened this issue May 23, 2019 · 5 comments · Fixed by #618
Closed

PrivateDevices=yes stops fping from working on Ubuntu 18.04 #609

trenta opened this issue May 23, 2019 · 5 comments · Fixed by #618
Labels
bug Something isn't working

Comments

@trenta
Copy link

trenta commented May 23, 2019

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 6.4.2
  • Ruby:
  • Distribution:
  • Module version: 6.7.0

How to reproduce (e.g Puppet code you use)

What are you seeing

All simple ICMP ping checks failing

What behaviour did you expect instead

Output log

fping failed: (null): can't create socket (must run as root?) : Permission denied

Any additional information you'd like to impart

This was found https://bugs.archlinux.org/task/60113

I understand that Ubuntu 18.04 isn't supported by this module yet though.

@grunt009
Copy link

grunt009 commented Jun 5, 2019

Same issue here, use of NoNewPrivileges=no seems not to work and produces the same error.
This also prevents use of ping in the web interface.

@luisgalang
Copy link

luisgalang commented Jul 26, 2019

Hi,
You should do two steps to get fping working in zabbix on Ubuntu 18.04:

  • chmod ug+s /usr/bin/fping
  • Comment the following line in /etc/systemd/system/zabbix-server.service
    #PrivateDevices=yes

I guess template file from the repo should be updated (https://github.com/voxpupuli/puppet-zabbix/blob/master/templates/zabbix-server-systemd.init.erb) to comment that line.

@jordips
Copy link
Contributor

jordips commented Jul 26, 2019

Same issue here. We are using it with ubuntu 18.04. I don't know if it's really useful in this case... but this prevents zabbix to work properly using fping.

@Samgarr
Copy link
Contributor

Samgarr commented Aug 15, 2019

Also issue here.
According to docs, PrivateDevices=yes implies NoNewPrivileges=yes, which prevent gaining pinger process setuid privileges or capabilities.

@juniorsysadmin juniorsysadmin added the bug Something isn't working label Aug 17, 2019
@xray-sky
Copy link

xray-sky commented Sep 17, 2019

I found that simply changing PrivateTmp=yes to PrivateTmp=no was all that was needed to fix the fping failure on the zabbix server in 18.04. Be nice to get this addressed one way or another, though.

The proxies are working with fping on 18.04 as-is (or at least I'm not seeing the same errors in the proxy logs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants