Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependencies need update #453

Closed
fox887 opened this issue Sep 27, 2017 · 3 comments
Closed

Dependencies need update #453

fox887 opened this issue Sep 27, 2017 · 3 comments
Labels
bug Something isn't working

Comments

@fox887
Copy link

fox887 commented Sep 27, 2017

Many modules were upgraded but puppet-zabbix is incompatible with some dependencies.

Warning: Module 'puppetlabs-apache' (v2.1.0) fails to meet some dependencies:
'puppet-zabbix' (v5.0.0) requires 'puppetlabs-apache' (>= 1.6.0 < 2.0.0)
Warning: Module 'puppetlabs-apt' (v4.1.0) fails to meet some dependencies:
'puppet-zabbix' (v5.0.0) requires 'puppetlabs-apt' (>= 2.1.0 < 3.0.0)
Warning: Module 'puppetlabs-concat' (v4.0.1) fails to meet some dependencies:
'puppet-zabbix' (v5.0.0) requires 'puppetlabs-concat' (>= 2.2.1 < 3.0.0)

├──puppet-zabbix (v5.0.0)
├── puppetlabs-apache (v2.1.0) invalid
├── puppetlabs-apt (v4.1.0) invalid
├── puppetlabs-concat (v4.0.1) invalid
@bastelfreak
Copy link
Member

Hi @fox887, thanks for this issue. are you able to provide a patch for this?

@juniorsysadmin
Copy link
Member

juniorsysadmin commented Sep 29, 2017 •
edited
Loading

Most of these except for maybe concat should be soft, soft and soft dependencies #330
See https://docs.puppet.com/puppet/latest/style_guide.html#dependencies

@juniorsysadmin juniorsysadmin added the bug Something isn't working label Sep 29, 2017
@fox887
Copy link
Author

fox887 commented Sep 29, 2017

I have changed the metadata.json manually to use the versions I have installed on my server and couldn't find any problem.

puppetlabs-apache' (v2.1.0)
puppetlabs-apt' (v4.1.0)
puppetlabs-concat' (v4.0.1)

I need more time to take a look at the code more deeply and check the changelog of those modules to understand what they have changed.

alexjfisher added a commit to alexjfisher/puppet-zabbix that referenced this issue Feb 13, 2018
@alexjfisher
Update module dependencies
b2b2229 
Fixes voxpupuli#453

We test against the latest versions and we've had reports that people
are successfully using this module with recent versions of
apache/concat/apt etc.

Some dependencies should probably be removed as they are 'soft'
dependencies.  This would at least need a README update though.  For
now, this commit is probably good enough to be worth merging.
@alexjfisher alexjfisher mentioned this issue Feb 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bastelfreak @juniorsysadmin @fox887