Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zabbix as default vhost #180

Closed
sergii-zemlianyi opened this issue Feb 25, 2016 · 7 comments
Closed

Zabbix as default vhost #180

sergii-zemlianyi opened this issue Feb 25, 2016 · 7 comments

Comments

@sergii-zemlianyi
Copy link
Contributor

Hi folks,

Did anyone face with issue when access to zabbix UI by IP address points to default vhost which is effectively just /var/www/ ?

I propose to make change in
apache::vhost { $zabbix_url }
and
apache::vhost { "${zabbix_url}_nonssl"}
resources to add attribute
manage_docroot => false

Tested on my env, I can now access Zabbix by IP.

BR,
Sergey

@dj-wasabi
Copy link
Contributor

Hi,

So you would like to propose the following change:
Add:

manage_docroot => false

This is only for allowing it via an ip instead of an fqdn? Am I correct?

@ju5t
Copy link
Contributor

ju5t commented Mar 3, 2016

You can do this already without changing any of the code if you set the following Apache class for your server.

class { 'apache':
  mpm_module => 'prefork',
  default_vhost => false,
  default_ssl_vhost => false,
}

@dj-wasabi
Copy link
Contributor

This is indeed easier to do, thank you @ju5t . If this work @szemlyanoy would you please let me know? I can update the documentation about this.

@sergii-zemlianyi
Copy link
Contributor Author

If I set

class profile::zabbix::server {
include ::zabbix::server
include ::zabbix::web
include ::zabbix::javagateway
include ::mysql::client
include ::apache::mod::php
class { 'apache':
mpm_module => 'prefork',
default_vhost => false,
default_ssl_vhost => false,
}
}

then I get obvious duplicate resource error of Class[Apache]. I don't want to set manage_vhost=>false and replicate all params of apache in node definition(or profile)

sergii-zemlianyi pushed a commit to sergii-zemlianyi/puppet-zabbix that referenced this issue Mar 29, 2016
@ju5t
Copy link
Contributor

ju5t commented Apr 1, 2016

You're setting defaults that may be causing issues on existing installations. We don't want Zabbix to be the default for example. You're also missing some documentation on your change.

@sergii-zemlianyi
Copy link
Contributor Author

ok for me it's absolutely fine to pass default 'false'.
Sorry what you mean by documentation?

dj-wasabi added a commit that referenced this issue Apr 11, 2016
@dj-wasabi
Copy link
Contributor

I'll close this issue as the PR is accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants