Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removal of mirrorlist is set by 'absent' not by using a knockout. #63

Closed
shawn-sterling opened this issue Aug 29, 2017 · 1 comment
Closed

Comments

@shawn-sterling
Copy link

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: puppet-agent-1.9.3-1.el6.x86_64
  • Ruby: Puppet-Agent packages 2.1.0
  • Distribution: Centos 6
  • Module version: 2.0.1-rc0

How to reproduce (e.g Puppet code you use)

Pass hiera data using a knockout for mirrorlist

yum::managed_repos:
  - 'base'

yum::manage_os_default_repos: false

yum::repos:
  base:
    enabled: true
    descr: 'CentOS-$releasever - Base'
    baseurl: 'https://my.artifactory.server/yum-centos/$releasever/os/$basearch/'
    mirrorlist: '--'
    gpgcheck: true
    gpgkey: "file:///etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-%{facts.os.release.major}"
    target: '/etc/yum.repos.d/CentOS-Base.repo'

What are you seeing

Error: Parameter mirrorlist failed on Yumrepo[base]: Validate method failed for class mirrorlist: Must be a valid URL at /etc/puppetlabs/code/environments/production/modules/yum/manifests/init.pp:130

What behaviour did you expect instead

The yumrepo resource is expecting 'absent' for mirrorlist not undef.

Any additional information you'd like to impart

Works fine if I set the mirrorlist to 'absent' , think this just needs an update to the documentation, or maybe you want to tackle this another way?

Have a good day.

-Shawn

@dhoppe
Copy link
Member

dhoppe commented Apr 5, 2019

This issue was fixed by the following commit

@dhoppe dhoppe closed this as completed Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants