--no-use-wheel renamed to --no-binary :all: in pip 7.0 and newer

[hmpf]

This leads to a warning including this string when pip installing:

DEPRECATION: --no-use-wheel is deprecated and will be removed in the future. Please use --no-binary :all: instead.

[KlavsKlavsen]

This is hitting me as well - trying to install puppetboard :(

[chgarling]

We are affected to. I am working on a pull request to fix this.

[slavaaaaaaaaaa]

@chgarling I'm working on figuring out how to fix this as well, for some reason in puppet pip isn't happy with --no-binary for me

[chgarling]

I made some tests on CentOS 7 without puppet and this module. If you create a new virtualenv with e.g. "virtualenv testenv" pip version 1.4.1 is installed. Because of pip is < 7.0 it does not understand --no-binary. Correct me if I am wrong with that. In my opinion the steps should be:

1. Create virtualenv
2. pip install --upgrade pip
3. all the other stuf

[chgarling]

I changed the python::virtualenv class. I added ${pip_cmd} install --upgrade pip after virtualenv creation. I also replaced --no-use-wheel with --no-binary :all:

With this modifications it applies fine. Could you try out my fork? If you are using Puppetfile:

mod 'stankevich-python', :git => 'https://github.com/chgarling/puppet-python.git

[chgarling]

First try was formatted as code.

[slavaaaaaaaaaa]

Fantastic, thank you @chgarling, I'll give it a try in a second

[chgarling]

Which OS are you testing on? CentOS, Debian, SLES?

[slavaaaaaaaaaa]

Centos 7

[chgarling]

Let me know if you have a result.

[slavaaaaaaaaaa]

@chgarling looks like that works fine. No errors, at least

[chgarling]

Recently I have no good idea how to handle the python::pip class regarding to the deprecated --no-use-wheel option. As I understand this class can be used with manually created virtualenvs, so the pip version is unknown.

pip <= 1.4.1 has no --no-use-wheel option
pip >= 1.5.0 <= 7.0.0 has the --no-use-wheel option but not --no-binary
pip >= 7.0.0 deprecates the --no-use-wheel option in favour to --no-binary

A variable with the pip version from the specific virtualenv is needed to set the right wheel_support_flag option. But how? Facts are to static in this case, nor?

[ghoneycutt]

There are different versions of pip per virtualenv, right? If so, how do you figure out which version of pip is installed in that virtualenv? Is it possible to specify the pip version when creating a virtualenv?

[chgarling]

@ghoneycutt if you use python::virtualenv the latest pip version is installed since my commit. On the other hand you can use the python::pip class with an already available virtualenv, in this case the pip version is unknown.

[mikkergimenez]

Does this PR to solve this issue still need more work? This issue could probably use a bump, as it could cause puppet runs to fail on newer versions of pip.

#366

[stankevich]

Fixed in #388