Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifests using the module aren't testable in windows #27

Closed
alonisser opened this issue Aug 21, 2013 · 2 comments
Closed

Manifests using the module aren't testable in windows #27

alonisser opened this issue Aug 21, 2013 · 2 comments

Comments

@alonisser
Copy link

When I run puppet test on my manifests using puppet-python:

puppet apply --noop --modulepath=modules manifests\default.pp

I just need to verify that puppet builds the correct catalog etc. but instead I get a Module is not compatible with windows error.

This is a common scenerio when using vagrant+puppet on windows to provision a virtual linux machine.
The problem comes from this code in init.pp:

  $compatible = [ 'Debian', 'Ubuntu', 'CentOS', 'RedHat' ]
  if ! ($::operatingsystem in $compatible) {
    fail("Module is not compatible with ${::operatingsystem}")
  }

Let me make my self clear This is a complete valid failure when running puppet apply on windows without the --noop flag.
But this shouldn't fail on a test scenerio. Maybe when --noop is on puppet arguments the module should notify but not fail.

@shivapoudel
Copy link
Contributor

This module is compatible with Debian and Redhat. Sorry for the inconvenience.

@igalic
Copy link
Contributor

igalic commented Aug 11, 2014

@shivapoudel I think a good start for enabling support would be to change the fail into a warning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants