Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not fail fatal if OS is unsupported. #304

Closed
jkroepke opened this issue Oct 20, 2018 · 1 comment · Fixed by #305
Closed

Do not fail fatal if OS is unsupported. #304

jkroepke opened this issue Oct 20, 2018 · 1 comment · Fixed by #305

Comments

@jkroepke
Copy link
Contributor

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 6.0.2
  • Ruby:
  • Distribution: Ubuntu 18.04
  • Module version: 7.3.0

How to reproduce (e.g Puppet code you use)

What are you seeing

Evaluation Error: Error while evaluating a Function Call, unsupported OS Ubuntu 18.04

What behaviour did you expect instead

Just working

Output log

Any additional information you'd like to impart

The module works totally fine under Ubuntu 18.04. I had no issues but I also do not test some edge cases.

Anyway please do not fail if the version is unsupported. I can understand if you auto config may not work for unsupported version but let the user the chance to configure the module manually.
@bastelfreak
Copy link
Member

hey Jan, can you provide a PR for this?

@jkroepke jkroepke mentioned this issue Oct 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Data in Modules, Modern facts & Cleanup jkroepke/puppet-openvpn
2 participants
@bastelfreak @jkroepke