Doesn't work properly with "remote" in openvpn::server

[cjeanneret]

Hello,

While using latest release (5.0.0), I have the following issue:

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Could not find resource 'Openvpn::Ca[lsn]' for relationship on 'Service[openvpn@lsn]' on node ip-192-168-4-8.sandbox.internal

The receipt raising this issue is:

  sysctl {'net.ipv4.ip_forward':
    value => 1,
  }
  -> class {'::openvpn': }
  -> file {
    '/etc/openvpn/ssl/lsn/keys/ca.crt':
      content => file('c2c_ssl/freeipa/ca.crt');
    '/etc/openvpn/ssl/lsn/keys/lsn.key':
      content => file("openstack/ssl/${project}.key");
    '/etc/openvpn/ssl/lsn/keys/lsn.crt':
      content => file("openstack/ssl/${project}.crt");
  }
  -> ::openvpn::server {'lsn':
    remote => ['foo.bar'],
  }

After checking the openvpn::server definition, I think the main issue is with the different parts that add the Openvpn::Ca[...] as a prerequisite of the Service['openvpn@name'], for example this one will not match the fact that we're actually using a remote:

  if $::openvpn::params::systemd {
    if $::openvpn::manage_service {
      service { "openvpn@${name}":
        ensure   => running,
        enable   => true,
        provider => 'systemd',
        require  => File["${etc_directory}/openvpn/${name}.conf"],
      }
      if !$extca_enabled {
        Openvpn::Ca[$ca_name] -> Service["openvpn@${name}"]
      }
    }
  }

source

As the ::openvpn::ca isn't called at all if $remote is non-null, that param should also be tested in order to add or not the prerequisite.

Thank you!

Cheers,

C.

[cjeanneret]

Had to modify the unit test in order to "prove" the issue - now the PR #253 is being checked on the CI :).

Lemme know if I need to do anything else on that matter. Locally, the rspec is all green.

[cjeanneret]

@juniorsysadmin or @bastelfreak or anyone in the team, care to merge the #253 and, maybe, do some release we can reach on the Forge this week? :) That would be really nice.

[cjeanneret]

merged in master - thanks @bastelfreak !