Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No support for Xenial with NodeJS6 #228

Closed
ColinHebert opened this issue Jun 2, 2016 · 3 comments
Closed

No support for Xenial with NodeJS6 #228

ColinHebert opened this issue Jun 2, 2016 · 3 comments

Comments

@ColinHebert
Copy link
Contributor

Currently attempting to install node6.x with Ubuntu Xenial fails with

Error: Evaluation Error: Error while evaluating a Function Call, Var $repo_url_suffix with value '6.x' is not set correctly for Ubuntu 16.04. See README. at /etc/puppetlabs/code/environments/production/modules/nodejs/manifests/init.pp:48:9 on node ....

It might be worth making the check less restrictive for newer versions/platforms
@bastelfreak
Copy link
Member

hi @ColinHebert, thanks for finding that bug. Are you able to also provide a PR with a fix?

@ColinHebert ColinHebert mentioned this issue Jun 2, 2016
Merged
@ColinHebert
Copy link
Contributor Author

Sure, dealt with in #229

@bastelfreak
Copy link
Member

merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ColinHebert @bastelfreak