Skip to content

Conversation

@zilchms
Copy link
Contributor

@zilchms zilchms commented Mar 15, 2025

Reduce indirection by reducing repository classes redirect levels.

@zilchms zilchms changed the title Rewrite repository classes Rewrite repository classes and drop manual management of debian erlang source Mar 15, 2025
@zilchms zilchms changed the title Rewrite repository classes and drop manual management of debian erlang source Restructure repository classes and drop manual management of debian erlang source Mar 15, 2025
'RedHat': {
contain erlang::repo::yum
}
'Debian': {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does it now work on Debian? Only use the packages from Debian.org? Is the erlang_solutions repo dead?

Copy link
Contributor Author

@zilchms zilchms Mar 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, it now uses the packages from debian. I am not sure what exactly is going on with the erlang_solutions repo. I know we lose a bit of configurability for debian this way, but at the very least we get the posibility to do work here again. Right now the metadata shows that we are falling behind on what OSes can be maintained. My thought process was: if the configurability is needed/wanted it can be added again later in a functional state.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should probably be another PR fully fixing the repo indirection problem at some point in the future. But i would have to look at the best practices for repo handling again before tackling that

class erlang::repo::yum (
String $ensure = $erlang::repo_ensure,
Erlang::RepoSource $source = $erlang::repo_source,
String $erlang_solutions_baseurl = "https://packages.erlang-solutions.com/rpm/centos/\$releasever/\$basearch",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update to the httpsurl datatype from stdlib

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed in #42

@smortex smortex merged commit 62eb991 into voxpupuli:master May 21, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants