-
-
Notifications
You must be signed in to change notification settings - Fork 6
Restructure repository classes and drop manual management of debian erlang source #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 'RedHat': { | ||
| contain erlang::repo::yum | ||
| } | ||
| 'Debian': {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does it now work on Debian? Only use the packages from Debian.org? Is the erlang_solutions repo dead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, it now uses the packages from debian. I am not sure what exactly is going on with the erlang_solutions repo. I know we lose a bit of configurability for debian this way, but at the very least we get the posibility to do work here again. Right now the metadata shows that we are falling behind on what OSes can be maintained. My thought process was: if the configurability is needed/wanted it can be added again later in a functional state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should probably be another PR fully fixing the repo indirection problem at some point in the future. But i would have to look at the best practices for repo handling again before tackling that
| class erlang::repo::yum ( | ||
| String $ensure = $erlang::repo_ensure, | ||
| Erlang::RepoSource $source = $erlang::repo_source, | ||
| String $erlang_solutions_baseurl = "https://packages.erlang-solutions.com/rpm/centos/\$releasever/\$basearch", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update to the httpsurl datatype from stdlib
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed in #42
Reduce indirection by reducing repository classes redirect levels.