Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote removal should be configurable #29

Open
parro-it opened this issue Sep 7, 2016 · 3 comments
Open

Quote removal should be configurable #29

parro-it opened this issue Sep 7, 2016 · 3 comments

Comments

@parro-it
Copy link
Collaborator

parro-it commented Sep 7, 2016

If expansion callback are not passed in options, quote removal should be avoid to allow a correct expansion on user side.

@parro-it
Copy link
Collaborator Author

Actually, we perform quote removal only if all of the substitutions found in a word are solved. Do you think there is still need of an option to disable quote removal also when there are no subst?

@piranna
Copy link
Collaborator

piranna commented Sep 13, 2016

I think they should be removed in all cases when possible also if not all of them has been replaced, because quotes only function is to work as delimiters and they have already done their purposse. On the other hand, a flag disabled by default to remove them is not bad, too.

@parro-it
Copy link
Collaborator Author

quotes only function is to work as delimiters and they have already done their purpose

If the parser remove quotes even when it didn't perform substitution, the caller may not be able to perform them by itself, because you lose the information if the word or part of it are quoted (e.g. if it's quoted between single quotes, substitution should not occcur)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants