Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added templates to verify #962

Merged
merged 1 commit into from
Oct 3, 2024
Merged

feat: added templates to verify #962

merged 1 commit into from
Oct 3, 2024

Conversation

manchuck
Copy link
Contributor

@manchuck manchuck commented Sep 24, 2024

This is adding template and template fragments to the SDK to verify V2

Description

Motivation and Context

Testing Details

Example Output or Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@manchuck manchuck force-pushed the verify-templates branch 9 times, most recently from 106a065 to e5e7361 Compare September 25, 2024 20:10
@manchuck manchuck marked this pull request as ready for review September 25, 2024 20:12
@manchuck manchuck force-pushed the verify-templates branch 3 times, most recently from 0bc8b73 to 6742472 Compare September 26, 2024 20:57
Copy link

@SecondeJK SecondeJK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're missing:
Create template
Get template
Update template
Delete template

get template fragment
update template fragment
delete template fragment

OR I cannot read Typescript very well, which I can't

@manchuck manchuck requested a review from SecondeJK October 1, 2024 17:47
@manchuck manchuck merged commit 98a1731 into 3.x Oct 3, 2024
10 of 11 checks passed
@manchuck manchuck deleted the verify-templates branch October 3, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants