Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(video): updated endpoints for adding/removing streams from Archive #922

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

conshus
Copy link
Contributor

@conshus conshus commented Mar 6, 2024

adds "s" to endpoints to match https://developer.vonage.com/en/api/video#patch-v2-project-application_id-archive-archive_id-streams

Description

adds "s" to endpoints to match https://developer.vonage.com/en/api/video#patch-v2-project-application_id-archive-archive_id-streams

Motivation and Context

Right now, the current endpoints return 404.

Testing Details

Example Output or Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@conshus conshus requested a review from dragonmantank March 6, 2024 21:03
@manchuck manchuck changed the title Update video.ts endpoints for adding/removing streams from Archive fix(video): updated endpoints for adding/removing streams from Archive Mar 6, 2024
Copy link
Contributor

@manchuck manchuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test needs to be updated

@conshus conshus requested a review from manchuck March 7, 2024 00:30
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.61%. Comparing base (fbe1c27) to head (6e04c6b).

Additional details and impacted files
@@           Coverage Diff           @@
##              3.x     #922   +/-   ##
=======================================
  Coverage   84.61%   84.61%           
=======================================
  Files         122      122           
  Lines        1775     1775           
  Branches      363      363           
=======================================
  Hits         1502     1502           
  Misses        273      273           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dragonmantank dragonmantank merged commit 9652cac into 3.x Mar 7, 2024
13 checks passed
@dragonmantank dragonmantank deleted the conshus-patch-1 branch March 7, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants