-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(messages): added new webhook, viber, and sms parameters #921
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.x #921 +/- ##
=======================================
Coverage 84.61% 84.62%
=======================================
Files 122 122
Lines 1775 1782 +7
Branches 363 367 +4
=======================================
+ Hits 1502 1508 +6
- Misses 273 274 +1 ☔ View full report in Codecov by Sentry. |
Added webhook parameters to all messages Updated viber video and file parameters Added SMS encoding and options to the SMS class Removed conversations dependency for server-client
866f68b
to
0489db3
Compare
a610acb
to
35efc13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Just a few things I noticed/ wanted to query:
-
In DEVX-7950 for MMS Outbound Messages, it outlines a new
caption
property for the MMSvCard
message type. However, in the current implementation of the Node SDK, it looks likeMMSVcardParams
is an intersection ofMessageParams
andMessageVcardType
, neither of which contains acaption
property. I can't see anything in this PR that changes that. -
In [DEVX-7950] (https://jira.vonage.com/browse/DEVX-7950), for WhatsApp
file
message type, ity states "Add optionalname
property (string) tofile
object", but I can't see this in the existing implementation or that it's added in this PR. (It looks likeWhatsAppFileParams
just exportsMessageParamsFile
which setsfile
toMessageFileType
-
In DEVX-7950 for Viber, is outlines a new
action
property as part of theviber_service
object, but this should be fortext
andimage
types only. In the current implementation it looks likeViberVideoParams
also setsviberService
to intersect withViberActionParams
(see} & ViberActionParams;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the updates. I think this is good to go.
Added missing params for files and vCard
67c5200
to
de1cdf2
Compare
Description
Added webhook parameters to all messages
Updated viber video and file parameters
Added SMS encoding and options to the SMS class
Removed conversations dependency for server-client
Motivation and Context
Testing Details
Example Output or Screenshots (if appropriate)
Types of changes
Checklist