Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(conversations): added conversations package #905

Merged
merged 9 commits into from
Feb 9, 2024
Merged

Conversation

manchuck
Copy link
Contributor

Description

Motivation and Context

Testing Details

Example Output or Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@manchuck manchuck force-pushed the conversations branch 3 times, most recently from 61c45a2 to 94182b0 Compare January 22, 2024 20:40
@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ad0d6c0) 83.44% compared to head (9ba308d) 84.52%.
Report is 6 commits behind head on 3.x.

Files Patch % Lines
packages/conversations/lib/conversations.ts 98.38% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              3.x     #905      +/-   ##
==========================================
+ Coverage   83.44%   84.52%   +1.07%     
==========================================
  Files         121      122       +1     
  Lines        1649     1777     +128     
  Branches      325      365      +40     
==========================================
+ Hits         1376     1502     +126     
- Misses        273      275       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manchuck manchuck marked this pull request as draft January 24, 2024 18:55
@manchuck manchuck force-pushed the conversations branch 2 times, most recently from fe54422 to b51347b Compare January 30, 2024 20:47
@manchuck manchuck marked this pull request as ready for review February 6, 2024 19:14
@manchuck manchuck requested a review from conshus February 8, 2024 14:21
Copy link
Contributor

@conshus conshus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So many types 🫡

manchuck and others added 7 commits February 9, 2024 12:53
Co-authored-by: Dwane Hemmings <[email protected]>
Co-authored-by: Dwane Hemmings <[email protected]>
Co-authored-by: Dwane Hemmings <[email protected]>
Co-authored-by: Dwane Hemmings <[email protected]>
@manchuck
Copy link
Contributor Author

manchuck commented Feb 9, 2024

@conshus You're telling me. The bulk of this PR is just all the types

Copy link
Contributor

@conshus conshus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@manchuck manchuck merged commit e28f6b6 into 3.x Feb 9, 2024
11 of 12 checks passed
@manchuck manchuck deleted the conversations branch February 9, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants