Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(number-insight-v2): added support for number insight v2 #868

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

manchuck
Copy link
Contributor

@manchuck manchuck commented Sep 27, 2023

Description

Motivation and Context

Testing Details

Example Output or Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@manchuck manchuck requested review from dragonmantank and removed request for dragonmantank September 27, 2023 20:27
@manchuck manchuck force-pushed the feat-number-insight-v2 branch from faac742 to 007ba88 Compare September 27, 2023 20:44
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2023

Codecov Report

Merging #868 (bb08004) into 3.x (670b83c) will increase coverage by 0.03%.
Report is 1 commits behind head on 3.x.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              3.x     #868      +/-   ##
==========================================
+ Coverage   83.87%   83.91%   +0.03%     
==========================================
  Files         121      122       +1     
  Lines        1619     1623       +4     
  Branches      311      311              
==========================================
+ Hits         1358     1362       +4     
  Misses        260      260              
  Partials        1        1              
Files Coverage Δ
packages/number-insight-v2/lib/numberInsightV2.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@manchuck manchuck marked this pull request as ready for review September 28, 2023 17:40
packages/server-sdk/lib/vonage.ts Outdated Show resolved Hide resolved
@manchuck manchuck force-pushed the feat-number-insight-v2 branch from 007ba88 to 3c8392a Compare October 12, 2023 19:59
@manchuck manchuck force-pushed the feat-number-insight-v2 branch from 3c8392a to bb08004 Compare October 12, 2023 20:06
Copy link
Contributor

@dragonmantank dragonmantank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manchuck manchuck merged commit 3e6a4dc into 3.x Oct 13, 2023
@manchuck manchuck deleted the feat-number-insight-v2 branch October 13, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants