Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(voice): adding advanced machine detection #835

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

manchuck
Copy link
Contributor

@manchuck manchuck commented Jun 7, 2023

Description

Motivation and Context

Testing Details

Example Output or Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2023

Codecov Report

Merging #835 (fa8de5a) into 3.x (858b41e) will decrease coverage by 1.47%.
The diff coverage is 48.99%.

❗ Current head fa8de5a differs from pull request most recent head 04b14b1. Consider uploading reports for the commit 04b14b1 to get more accurate results

@@            Coverage Diff             @@
##              3.x     #835      +/-   ##
==========================================
- Coverage   83.42%   81.96%   -1.47%     
==========================================
  Files         119      117       -2     
  Lines        1484     1325     -159     
  Branches      282      259      -23     
==========================================
- Hits         1238     1086     -152     
+ Misses        245      238       -7     
  Partials        1        1              
Impacted Files Coverage Δ
packages/voice/lib/classes/NCCO/Record.ts 1.35% <1.35%> (+1.35%) ⬆️
packages/voice/lib/classes/NCCO/Connect.ts 2.38% <2.38%> (+2.38%) ⬆️
packages/voice/lib/classes/NCCO/Stream.ts 5.55% <5.55%> (+5.55%) ⬆️
packages/voice/lib/classes/NCCO/Notify.ts 9.09% <9.09%> (+9.09%) ⬆️
packages/voice/lib/classes/NCCO/Talk.ts 60.00% <60.00%> (ø)
packages/voice/lib/classes/NCCO/Conversation.ts 61.76% <61.76%> (ø)
packages/voice/lib/classes/OutboundCall.ts 71.42% <71.42%> (ø)
packages/voice/lib/classes/NCCO/Input.ts 77.77% <77.77%> (ø)
packages/voice/lib/voice.ts 95.45% <95.45%> (ø)
packages/voice/lib/classes/NCCO/NCCOBuilder.ts 100.00% <100.00%> (ø)
... and 21 more

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@manchuck manchuck force-pushed the feat-advanced-machine-detection branch 4 times, most recently from 82aaa6a to fa8de5a Compare June 14, 2023 20:40
@manchuck manchuck marked this pull request as ready for review June 14, 2023 20:48
@manchuck manchuck requested a review from dragonmantank June 14, 2023 20:48
@manchuck manchuck added the don't merge Don't merge this code at this time label Jun 22, 2023
@manchuck manchuck force-pushed the feat-advanced-machine-detection branch 2 times, most recently from 6464ba6 to bbd7178 Compare June 26, 2023 19:26
@manchuck manchuck force-pushed the feat-advanced-machine-detection branch from bbd7178 to 04b14b1 Compare June 26, 2023 19:29
@manchuck manchuck merged commit 1739320 into 3.x Jun 26, 2023
@manchuck manchuck deleted the feat-advanced-machine-detection branch June 26, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
don't merge Don't merge this code at this time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants